-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task/WG-295-WG-179-WG-185: fix and improve projects with duplicate system path constraints #216
Conversation
We can refresh users more often so setting that to every 30 minutes.
…ojects-with-duplicate-system-path-constraints
We should add logic to the backend routes that prevents a user from creating a new map in a project that is already syncing (even though we do not expose this on the client-side front-end, a user could still call the API and create a map there that violates our syncing constraints). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic all LGTM. I left a slew of comments related to the naming-of-things. Do with them what you wish.
Firefox had the longest max among browsers.
Addressed. Turns out we only allow |
…ojects-with-duplicate-system-path-constraints
…ojects-with-duplicate-system-path-constraints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and working as expected. LGTM
Overview:
This PR does the following for users:
This PR also refactors the code by:
Related to TACC-Cloud/hazmapper#255
Related Jira tickets:
Summary of Changes:
Testing Steps:
Sync Folder
is not checked. Having two maps in the same directory should now be allowedSync Folder
checked. The creation of the second map should fail.Notes:
TODO
and stagingdata to ensure migration is functioning.